-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an alias to the shopify theme serve
command
#1257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Benchmark reportThe following table contains a summary of the startup time for all commands.
|
karreiro
force-pushed
the
theme-serve
branch
2 times, most recently
from
February 1, 2023 05:58
8788dd6
to
0813398
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success957 tests passing in 485 suites. Report generated by 🧪jest coverage report action from b1ac7e4 |
pepicrft
reviewed
Feb 3, 2023
import Dev from './dev.js' | ||
import {renderWarning} from '@shopify/cli-kit/node/ui' | ||
|
||
export default class Serve extends Dev { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the conciseness of this PR 👏🏼
pepicrft
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Some theme developers are used to call
shopify theme serve
.WHAT is this pull request doing?
This PR introduces an alias with a warning to the
shopify theme serve
command.How to test your changes?
Post-release steps
None.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.