Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alias to the shopify theme serve command #1257

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

karreiro
Copy link
Contributor

WHY are these changes introduced?

Some theme developers are used to call shopify theme serve.

WHAT is this pull request doing?

This PR introduces an alias with a warning to the shopify theme serve command.

How to test your changes?

Screenshot 2023-01-31 at 19 03 32

Post-release steps

None.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline (avg) Current (avg) Diff
🟢 app build 901.33 ms 904.33 ms 0.33 %
🟢 app deploy 1099.67 ms 1100.33 ms 0.06 %
🟢 app dev 1091.33 ms 1091.33 ms 0 %
🟢 app env pull 1004 ms 1000.33 ms -0.37 %
🟢 app env show 990.67 ms 1008.67 ms 1.82 %
🟢 app generate extension 1056 ms 1055.67 ms -0.03 %
🟢 app generate schema 1011 ms 1036 ms 2.47 %
🟢 app info 1002.67 ms 1011 ms 0.83 %
🟢 app scaffold extension 1061 ms 1068.67 ms 0.72 %
🟢 app update-url 978 ms 988.67 ms 1.09 %
🟢 theme check 848.67 ms 849.67 ms 0.12 %
🟢 theme delete 952 ms 946.67 ms -0.56 %
🟢 theme dev 945.67 ms 956 ms 1.09 %
🟢 theme help-old 834.33 ms 856 ms 2.6 %
🟢 theme info 879.33 ms 902.33 ms 2.62 %
🟢 theme init 864.67 ms 865.67 ms 0.12 %
🟢 theme language-server 833.33 ms 837.67 ms 0.52 %
🟢 theme list 947 ms 955 ms 0.84 %
🟢 theme open 958.33 ms 964.67 ms 0.66 %
🟢 theme package 898 ms 894 ms -0.45 %
🟢 theme publish 954.33 ms 955 ms 0.07 %
🟢 theme pull 947.67 ms 956 ms 0.88 %
🟢 theme push 947.67 ms 950.67 ms 0.32 %
⚪️ theme serve N/A 951,938,939 ms N/A
🟢 theme share 948.67 ms 948.67 ms 0 %
🟢 webhook trigger 952 ms 953 ms 0.11 %

@karreiro karreiro force-pushed the theme-serve branch 2 times, most recently from 8788dd6 to 0813398 Compare February 1, 2023 05:58
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
70.95% (-0.09% 🔻)
3758/5297
🟡 Branches
67.98% (+0.08% 🔼)
1654/2433
🟡 Functions
69.32% (-0.25% 🔻)
976/1408
🟡 Lines
72.04% (-0.11% 🔻)
3581/4971
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / theme.ts
39.13% (-26.09% 🔻)
0% (-50% 🔻)
18.18% (-27.27% 🔻)
40.91% (-27.27% 🔻)
🔴
... / output.ts
47.22% (-14.68% 🔻)
25% (-5% 🔻)
55.56% (-11.11% 🔻)
45.16% (-19.54% 🔻)
🟢
... / ConcurrentOutput.tsx
100% (+3.57% 🔼)
80% (-10.91% 🔻)
100% (+7.69% 🔼)
100%
🔴
... / ui.tsx
28.57% (-3.25% 🔻)
50% (+50% 🔼)
31.58%
33.33% (-3.51% 🔻)

Test suite run success

957 tests passing in 485 suites.

Report generated by 🧪jest coverage report action from b1ac7e4

import Dev from './dev.js'
import {renderWarning} from '@shopify/cli-kit/node/ui'

export default class Serve extends Dev {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the conciseness of this PR 👏🏼

@karreiro karreiro merged commit b69bee8 into main Feb 3, 2023
@karreiro karreiro deleted the theme-serve branch February 3, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants