Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert update checkout UI template #1300

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

vividviolet
Copy link
Member

@vividviolet vividviolet commented Feb 6, 2023

Revert the update to checkout ui extension template (#1275)

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-developer-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.78% (-0.03% 🔻)
3940/5489
🟡 Branches
69.19% (-0.04% 🔻)
1781/2574
🟡 Functions
70.18% (-0.04% 🔻)
1033/1472
🟡 Lines
73.01% (-0.04% 🔻)
3758/5147
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension.ts
96.43% (-3.57% 🔻)
91.67% (-8.33% 🔻)
100%
96% (-4% 🔻)
🟢
... / generate.ts
95.35% (-0.11% 🔻)
89.29%
88.89% (-1.11% 🔻)
97.3% (-0.14% 🔻)

Test suite run success

1010 tests passing in 518 suites.

Report generated by 🧪jest coverage report action from 64b107c

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline (avg) Current (avg) Diff
🟢 app build 1363 ms 1405 ms 3.08 %
🟢 app deploy 1644 ms 1699.33 ms 3.37 %
🟢 app dev 1679 ms 1688.33 ms 0.56 %
🟢 app env pull 1531 ms 1561 ms 1.96 %
🟢 app env show 1563.33 ms 1540.67 ms -1.45 %
🟢 app generate extension 1559 ms 1623.67 ms 4.15 %
🟢 app generate schema 1544.67 ms 1564.33 ms 1.27 %
🟢 app info 1507.33 ms 1544 ms 2.43 %
🟢 app scaffold extension 1570 ms 1614.67 ms 2.85 %
🟢 app update-url 1451.33 ms 1481 ms 2.04 %
🟢 theme check 1258.33 ms 1275.33 ms 1.35 %
🟢 theme delete 1419.67 ms 1449.33 ms 2.09 %
🟢 theme dev 1443 ms 1476 ms 2.29 %
🟢 theme help-old 1250.67 ms 1237.33 ms -1.07 %
🟢 theme info 1313.33 ms 1350 ms 2.79 %
🟢 theme init 1336.67 ms 1315.67 ms -1.57 %
🟢 theme language-server 1248.33 ms 1274.33 ms 2.08 %
🟢 theme list 1456.67 ms 1479 ms 1.53 %
🟢 theme open 1476 ms 1427 ms -3.32 %
🟢 theme package 1330 ms 1364 ms 2.56 %
🟢 theme publish 1443.33 ms 1450.33 ms 0.48 %
🟢 theme pull 1438.33 ms 1472.67 ms 2.39 %
🟢 theme push 1475.33 ms 1439.33 ms -2.44 %
🟢 theme serve 1465.33 ms 1528.33 ms 4.3 %
🟢 theme share 1429 ms 1441 ms 0.84 %
🟢 webhook trigger 1477.67 ms 1483.33 ms 0.38 %

@gonzaloriestra gonzaloriestra merged commit 91b18f5 into main Feb 6, 2023
@gonzaloriestra gonzaloriestra deleted the revert-update-checkout-ui-template branch February 6, 2023 17:19
@shopify-shipit shopify-shipit bot temporarily deployed to production February 6, 2023 17:35 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly February 7, 2023 02:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants