Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows line-endings in TOML files #2498

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

matteodepalo
Copy link
Contributor

Taking inspiration from cloudflare/workers-sdk#936

Our TOML parsing code is susceptible to the same issue so I'm preventively fixing it.

Verified

This commit was signed with the committer’s verified signature.
matteodepalo Matteo Depalo
@github-actions
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.83% (+0.04% 🔼)
5577/7554
🟡 Branches
70.71% (-0.02% 🔻)
2702/3821
🟡 Functions
72.67% (+0.03% 🔼)
1436/1976
🟡 Lines
75.5% (+0.09% 🔼)
5316/7041
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / flow_action.ts
100% 100% 100% 100%
🟢
... / flow_trigger.ts
100% 100% 100% 100%
🟢
... / checkout_post_purchase.ts
100% 100% 100% 100%
🟢
... / customer_accounts_ui_extension.ts
100% 100% 100% 100%
🟢
... / pos_ui_extension.ts
100% 100% 100% 100%
🟢
... / tax_calculation.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension-instance.ts
86.54% (-0.13% 🔻)
77.5%
93.75% (-0.19% 🔻)
88.54% (-0.12% 🔻)
🟢
... / context.ts
93.78%
87.3% (-0.2% 🔻)
100% 95.03%
🟢
... / link.ts
88.46% (-1.73% 🔻)
72.55% (-11.17% 🔻)
100%
88.46% (-1.73% 🔻)
🟢
... / prompts.ts
82.86% (-2.86% 🔻)
84.85% (+2.8% 🔼)
76% (-4% 🔻)
84.13% (-2.29% 🔻)
🟢
... / serialize-fields.ts
96.77% (-0.2% 🔻)
95.45% (+3.15% 🔼)
100% 100%
🟢
... / metadata.ts
96%
87.5% (-1.39% 🔻)
100% 96%

Test suite run success

1323 tests passing in 647 suites.

Report generated by 🧪jest coverage report action from 2e9b8f4

Copy link
Contributor

@amcaplan amcaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see a small test, especially if it shows the value of this.

@matteodepalo matteodepalo added this pull request to the merge queue Jul 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2023
@matteodepalo matteodepalo added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit b25dacd Jul 24, 2023
@matteodepalo matteodepalo deleted the line-endings-windows branch July 24, 2023 08:55
@shopify-shipit shopify-shipit bot temporarily deployed to nightly July 24, 2023 09:09 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production July 26, 2023 11:18 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to stable_3_48 August 4, 2023 14:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants