Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ink dependency error and only extension apps using yarn #2945

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

alvaro-shopify
Copy link
Contributor

@alvaro-shopify alvaro-shopify commented Oct 9, 2023

WHY are these changes introduced?

Moved to main this PR from stable

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-code-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.96% (-0.01% 🔻)
6085/8227
🟡 Branches
71.18% (-0.02% 🔻)
2976/4181
🟡 Functions 72.51% 1548/2135
🟡 Lines
75.27% (-0.01% 🔻)
5775/7672
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
97.62% (-2.38% 🔻)
75% (-8.33% 🔻)
100%
97.44% (-2.56% 🔻)

Test suite run success

1447 tests passing in 673 suites.

Report generated by 🧪jest coverage report action from 6e6065d

Co-authored-by: Ju Liu <ju.liu@shopify.com>
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit efc9adf Oct 11, 2023
1 check passed
@gonzaloriestra gonzaloriestra deleted the fix-ink-dependency-with-yarn branch October 11, 2023 07:18
@shopify-shipit shopify-shipit bot temporarily deployed to experimental October 16, 2023 14:05 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly October 16, 2023 17:10 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production October 19, 2023 13:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants