Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link overwrites redirect urls #3378

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

alvaro-shopify
Copy link
Contributor

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-app-foundations/issues/886

WHAT is this pull request doing?

  • In the link command when local configuration is merged the remote one, a replace with remote strategy is used instead of union, for any array property

How to test your changes?

  • Run dev to automatically update app URLs
  • Run link, the redirect_urls property content is overwritten with the remote one

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.96% (-0.02% 🔻)
6666/9013
🟡 Branches
71.08% (-0.04% 🔻)
3269/4599
🟡 Functions
73.49% (+0.01% 🔼)
1744/2373
🟡 Lines
75.02% (-0.03% 🔻)
6288/8382
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
97.62% (-2.38% 🔻)
75% (-8.33% 🔻)
100%
97.44% (-2.56% 🔻)

Test suite run success

1594 tests passing in 743 suites.

Report generated by 🧪jest coverage report action from f3210b8

Copy link
Contributor

@alexanderMontague alexanderMontague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about the test, but tophat works as expected 👍

@alvaro-shopify alvaro-shopify added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 583be8a Feb 7, 2024
@alvaro-shopify alvaro-shopify deleted the link-overwrites-redirect-urls branch February 7, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants