Remove API Client config from link command
#3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1580 tests passing in 738 suites. Report generated by 🧪jest coverage report action from 8e37004 |
gonzaloriestra
requested changes
Feb 9, 2024
There was a problem hiding this comment.
I've tried creating a new app and running link, but I'm getting an error:
Fix a schema error in /Users/gonzalo/tests/2024-02-09/shopify.app.toml: │
│ [ │
│ { │
│ "code": "invalid_type", │
│ "expected": "string", │
│ "received": "undefined", │
│ "path": [ │
│ "name" │
│ ], │
│ "message": "Required" │
│ }, │
│ { │
│ "code": "invalid_type", │
│ "expected": "object", │
│ "received": "undefined", │
│ "path": [ │
│ "auth" │
│ ], │
│ "message": "Required" │
│ }, │
│ { │
│ "code": "invalid_type", │
│ "expected": "object", │
│ "received": "undefined", │
│ "path": [ │
│ "webhooks" │
│ ], │
│ "message": "Required" │
│ }, │
│ { │
│ "code": "invalid_type", │
│ "expected": "string", │
│ "received": "undefined", │
│ "path": [ │
│ "application_url" │
│ ], │
│ "message": "Required" │
│ }, │
│ { │
│ "code": "invalid_type", │
│ "expected": "boolean", │
│ "received": "undefined", │
│ "path": [ │
│ "embedded" │
│ ], │
│ "message": "Required" │
│ } │
│ ]
| '@shopify/app': patch | ||
| --- | ||
|
|
||
| Remove api client configuration from the link command |
There was a problem hiding this comment.
This is transparent for the users, I think we don't need a changelog entry.
alvaro-shopify
force-pushed
the
remove-api-client-config-from-link
branch
from
3564dab
to
8e37004
Compare
gonzaloriestra
approved these changes
Feb 9, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Partially Fixes: https://github.com/Shopify/develop-app-management/issues/1612
Versioned app configuration has been 100% rolled out altogether with the 3.55.0 release. That means that the CLI should not use
api client configurationanymoreWHAT is this pull request doing?
linkcommand is not merging the remote API Client configurationAPI Client configurationfrom theappAPI requestsHow to test your changes?
linkcommand should work as expectedPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.