Fix shopify theme dev issue to avoid previewing the live theme instead of the development one

[karreiro]

WHY are these changes introduced?

Fixes #3466

WHAT is this pull request doing?

It seems like the caching policy at SFR has changed, so we're implementing this temporary solution to clean it and mitigate the issue.

How to test your changes?

• Delete your current development theme with shopify-dev theme delete -t <development_theme_id>
• Run shopify theme dev
• Notice that the localhost no longer loads the live theme; and the theme in localhost matches with the preview theme

Before

After

Post-release steps

None.

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

[github-actions]

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

• Themes: @shopify/advanced-edits
• UI extensions: @shopify/ui-extensions-cli
  • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
• Hydrogen: @shopify/hydrogen
• Other: @shopify/cli-foundations

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	73.67% (+0.05% 🔼)	6604/8964
🟡	Branches	70.37% (+0.05% 🔼)	3202/4550
🟡	Functions	73.1% (+0.05% 🔼)	1745/2387
🟡	Lines	74.68% (+0.05% 🔼)	6228/8340

Show new covered files 🐣

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / GitDiff.tsx	100%	87.5%	100%	100%

Test suite run success

1579 tests passing in 738 suites.

Report generated by 🧪jest coverage report action from 57b51c3

[edmeehan]

Additional instructions are needed. I followed the instructions and can only confirm that the localhost link works in an incognito window. Does not work on standard window. I also attempted to clear local storage, cache, and cookies in standard window but still the same result.

CLI localhost is serving published theme not local files on "shopify theme dev" cli command.

[architchandra]

Posting my comment here as well since #3466 has been closed and I fear that no one will look at it.

---

I'm working on a theme app extension and am facing a lot of issues where any change that I'm making in the code is not reflecting on the development store preview page that I'm adding the app block to (product pages). The changes are showing up only if I reload the product page several minutes after I made the code change. This is making the development effort extremely infuriating (sorry). I'm wondering if my problem is also related to this issue. Any fix or suggestion on this front will be greatly appreciated. Thanks.

What I've tried so far (unsuccessfully):

• Reloading the dev store product page on which I'm rendering the data using the theme app extension
• Disabling the cache for this page and reloading (initially assuming this to be a browser caching issue)
• Deploying the extension again using npm run deploy and then previewing again using npm run dev. A support forum thread suggested that this might work.
• Upgrading the @shopify/cli package to 3.56.3 after seeing the latest release, but it has sadly not helped.

More info:

• Shopify CLI v3.56.2 (npm package)
• MacOS Ventura 13.6.3
• Node v18.18.2