Make the fetching of dashboard extensions generic #3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show new covered files 🐣
Test suite run success1615 tests passing in 754 suites. Report generated by 🧪jest coverage report action from 15f2703 |
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
isaacroldan
approved these changes
Mar 22, 2024
yigitozkavci
force-pushed
the
introduce-import-payments-extension
branch
from
ac7aed2
to
15f2703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related: https://github.com/Shopify/payments-platform/issues/4387
We are about to introduce migration capability for payments extensions. This PR is laying the groundwork for generalising the existing business logic for importing an existing extension into CLI environment.
WHAT is this pull request doing?
In its current state, PR should be no-op and should be treated as refactoring.
How to test your changes?
Existing tests should provide enough confidence, as we haven't introduced any new business logic.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.