Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add changeset for editor extension collection #3608

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

oluwatimio
Copy link
Contributor

@oluwatimio oluwatimio commented Mar 27, 2024

WHY are these changes introduced?

Adds changeset for #3551

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@@ -0,0 +1,6 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to create this file manually. I did not see any documentation pointing out how to generate a new change set

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.2% 6746/9344
🟡 Branches 69.29% 3294/4754
🟡 Functions 70.88% 1799/2538
🟡 Lines 73.37% 6361/8670

Test suite run success

1615 tests passing in 754 suites.

Report generated by 🧪jest coverage report action from 6c76035

Copy link
Contributor

@ryancbahan ryancbahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ryancbahan ryancbahan merged commit ed27915 into main Mar 27, 2024
@ryancbahan ryancbahan deleted the change-set-editor-extension-collection branch March 27, 2024 17:16
Copy link
Contributor

@alfonso-noriega alfonso-noriega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am late but LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants