Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return full app from selectApp #3640

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Apr 2, 2024

Porting #3638 to stable

If an app was found after searching, it won't be sufficient to return
the API key, as the app may not be in the original list which the caller
has access to.
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/tcp.d.ts
@@ -1,11 +1,10 @@
 /**
  * Returns an available port in the current environment.
  *
- * @param preferredPort - Number of the preferred port to be used if available.
  * @returns A promise that resolves with an availabe port.
  * @example
  */
-export declare function getAvailableTCPPort(preferredPort?: number): Promise<number>;
+export declare function getAvailableTCPPort(): Promise<number>;
 /**
  * Checks if a port is available.
  *
packages/cli-kit/dist/public/node/api/business-platform.d.ts
@@ -1,6 +1,6 @@
 import { GraphQLVariables } from './graphql.js';
 /**
- * Executes a GraphQL query against the Business Platform Destinations API.
+ * Executes a GraphQL query against the Business Platform API.
  *
  * @param query - GraphQL query to execute.
  * @param token - Business Platform token.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.19% 6745/9344
🟡 Branches 69.27% 3293/4754
🟡 Functions 70.91% 1799/2537
🟡 Lines 73.35% 6360/8671

Test suite run success

1615 tests passing in 754 suites.

Report generated by 🧪jest coverage report action from 00f873d

@amcaplan amcaplan merged commit 1951e95 into stable/3.58 Apr 2, 2024
@amcaplan amcaplan deleted the patch-fix-selecting-old-app-to-stable branch April 2, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants