-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes] Remove requirement to provide name
flag in theme rename
command
#3644
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
1599bf9
to
58a0586
Compare
This comment has been minimized.
This comment has been minimized.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1617 tests passing in 754 suites. Report generated by 🧪jest coverage report action from 3386979 |
ec434a6
to
b6dc5d7
Compare
c685147
to
4742383
Compare
4742383
to
3386979
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/themes/utils.d.ts@@ -3,4 +3,5 @@ export declare const DEVELOPMENT_THEME_ROLE = "development";
export declare const LIVE_THEME_ROLE = "live";
export declare const UNPUBLISHED_THEME_ROLE = "unpublished";
export type Role = typeof DEVELOPMENT_THEME_ROLE | typeof LIVE_THEME_ROLE | typeof UNPUBLISHED_THEME_ROLE;
-export declare function isDevelopmentTheme(theme: Theme): boolean;
\ No newline at end of file
+export declare function isDevelopmentTheme(theme: Theme): boolean;
+export declare function promptThemeName(message: string): Promise<string>;
\ No newline at end of file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jamesmengo! 🚀
WHY are these changes introduced?
rename
commandWHAT is this pull request doing?
How to test your changes?
pnpm test
Google.Chrome.-.Shopify.-.Calendar.-.Week.of.March.31.2024.mp4