Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pnpm version on shipit scripts #3724

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

On shipit we were always installing the latest pnpm version, but they just relesed version 9.0.0 which is incompatible with our project.

WHAT is this pull request doing?

  • Force shipit to use pnpm version 8.15.7

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72% 6929/9623
🟡 Branches 69.08% 3412/4939
🟡 Functions 71.19% 1851/2600
🟡 Lines 73.28% 6534/8917

Test suite run success

1653 tests passing in 765 suites.

Report generated by 🧪jest coverage report action from 7fb3357

@isaacroldan isaacroldan merged commit 03c6419 into main Apr 16, 2024
1 check passed
@isaacroldan isaacroldan deleted the fix-pnpm-version-on-shipit-scripts branch April 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants