[3.59][Themes][Bugfix] - Fix unpublished themes being marked as development themes #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Coverage report
Test suite run success1653 tests passing in 765 suites. Report generated by 🧪jest coverage report action from 164f73a |
jamesmengo
force-pushed
the
jmeng/devthemes_3.59
branch
from
b8f0f5f
to
efc1069
Compare
Flush development theme local storage Add changeset PR Feedback Render live theme confirmation on selected theme role rather than on live flag
jamesmengo
force-pushed
the
jmeng/devthemes_3.59
branch
from
efc1069
to
164f73a
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.59.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.59.1";
\ No newline at end of file
|
karreiro
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting
TL;DR - Unpublished themes were getting marked as development themes