-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Include theme-check-docs-updater
data folder in final bundled dist
#3865
Merged
isaacroldan
merged 5 commits into
stable/3.60
from
fix-theme-check-update-default-files-stab
May 10, 2024
Merged
[stable] Include theme-check-docs-updater
data folder in final bundled dist
#3865
isaacroldan
merged 5 commits into
stable/3.60
from
fix-theme-check-update-default-files-stab
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1637 tests passing in 763 suites. Report generated by 🧪jest coverage report action from fb97b00 |
charlespwd
force-pushed
the
fix-theme-check-update-default-files-stab
branch
from
May 7, 2024 19:05
8ae82c4
to
8558aa3
Compare
charlespwd
reviewed
May 7, 2024
charlespwd
reviewed
May 7, 2024
charlespwd
force-pushed
the
fix-theme-check-update-default-files-stab
branch
from
May 10, 2024 12:23
8558aa3
to
15b9947
Compare
Use SHOPIFY_TMP_FLAG_DEBUG
charlespwd
force-pushed
the
fix-theme-check-update-default-files-stab
branch
from
May 10, 2024 12:24
15b9947
to
fb97b00
Compare
charlespwd
approved these changes
May 10, 2024
alexanderMontague
approved these changes
May 10, 2024
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There is a bug in theme check where some expected assets can't be found. This is because on the bundled CLI we need to explicitly copy any asset folder.
WHAT is this pull request doing?
data
folder fromtheme-check-data-updater
into the final bundleddist
folder.How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.