Allow CORS for checking if GraphiQL is running #3969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Shopify.dev wants to verify CLI's GraphiQL server is running so we can forward code examples from our LLM assistant.
CORS policies currently restrict us from pinging the GraphiQL server.
WHAT is this pull request doing?
This PR loosens the CORS policy for
/graphiql/ping
How to test your changes?
shopify app dev
inside a Shopify app (with this code checked out)fetch('http://localhost:3457/graphiql/ping').then(console.log)
ok === true
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.