-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the output for unhandled errors #3977
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1684 tests passing in 781 suites. Report generated by 🧪jest coverage report action from 08b6acc |
This comment has been minimized.
This comment has been minimized.
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -5,7 +5,7 @@ declare abstract class BaseCommand extends Command {
static analyticsNameOverride(): string | undefined;
static analyticsStopCommand(): string | undefined;
catch(error: Error & {
- exitCode?: number | undefined;
+ skipOclifErrorHandling: boolean;
}): Promise<void>;
protected init(): Promise<any>;
protected showNpmFlagWarning(): void;
|
WHY are these changes introduced?
Unhandled errors are shown twice:
WHAT is this pull request doing?
skipOclifErrorHandling
to prevent Oclif from printing the error, which is already shown by the CLIHow to test your changes?
packages/cli/src/cli/commands/version.ts
and addthrow new Error('Boom!')
at the beginning ofrun()
p shopify version
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.