-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Match webhooks by comparing relative and absolute paths #4150
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1720 tests passing in 794 suites. Report generated by 🧪jest coverage report action from 3f98e53 |
packages/app/src/cli/services/context/identifiers-extensions.ts
Outdated
Show resolved
Hide resolved
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.63.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.63.1";
\ No newline at end of file
|
WHY are these changes introduced?
The backend always returns an absolute path, but the CLI might only have relative ones.
WHAT is this pull request doing?
Use
endsWith
to compare relative and absolute URIsHow to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist