Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dunk.dont link patch #4267

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Dunk.dont link patch #4267

merged 2 commits into from
Aug 5, 2024

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Aug 5, 2024

Patching #4261 to stable

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

@amcaplan amcaplan changed the base branch from main to stable/3.65 August 5, 2024 12:19
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.59% (+0.08% 🔼)
7904/10888
🟡 Branches
69.35% (+0% 🔼)
3879/5593
🟡 Functions
71.31% (+0.02% 🔼)
2075/2910
🟡 Lines
72.93% (+0.09% 🔼)
7469/10242
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / dev.ts
74.42% (-1.67% 🔻)
56.25% (-8.75% 🔻)
76.47%
69.44% (-3.06% 🔻)
🟢
... / select-store.ts
86% (-0.27% 🔻)
81.82% 85.71%
87.23% (-0.27% 🔻)
🔴
... / developer-platform-client.ts
54.84% (-5.16% 🔻)
36.84% (-6.02% 🔻)
77.78% (-2.22% 🔻)
52% (-5.14% 🔻)
🟢
... / ConcurrentOutput.tsx
98.39% (-1.61% 🔻)
90.91% (-4.55% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1802 tests passing in 822 suites.

Report generated by 🧪jest coverage report action from bd3b48e

@amcaplan amcaplan merged commit dfe2df3 into stable/3.65 Aug 5, 2024
37 checks passed
@amcaplan amcaplan deleted the dunk.dont-link-patch branch August 5, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants