-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running Javy and function-runner on Windows #4274
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1807 tests passing in 822 suites. Report generated by 🧪jest coverage report action from 8fa8542 |
/snapit |
🫰✨ Thanks @jeffcharles! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g shopify@0.0.0-snapshot-20240806161156
|
This comment has been minimized.
This comment has been minimized.
Should I be including a changeset entry for this change? I didn't on the original change because it should have been invisible to the end user. |
@jeffcharles This definitely needs a patch-level changeset if we will be releasing the bugfix as a patch to the current minor version. Otherwise the release system won't be able to increment a version. |
Fixes bug on Windows where Javy and function-runner binaries are not executing because the file names do not end with
.exe
. Also adds installing and executing both binaries to the test suite.WHY are these changes introduced?
Javy was not was not running on Windows because the executable did not end in
.exe
.WHAT is this pull request doing?
Adds
.exe
to the Javy and function-runner binary names on Windows.How to test your changes?
If you're on Windows, using cmd:
pnpm shopify app build --path <path_to_app>
will perform the initial download of Javy.pnpm shopify app build --path <path_to_app>
will test that it uses the downloaded version of Javy.echo {} | pnpm shopify app function run --path <path_to_js_function_extension>
will test the initial download of function-runner.echo {} | pnpm shopify app function run --path <path_to_js_function_extension>
will it uses the downloaded version of function-runner.Measuring impact
How do we know this change was effective? Please choose one:
Checklist