Fix running Javy and function-runner on Windows #4274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug on Windows where Javy and function-runner binaries are not executing because the file names do not end with
.exe
. Also adds installing and executing both binaries to the test suite.WHY are these changes introduced?
Javy was not was not running on Windows because the executable did not end in
.exe
.WHAT is this pull request doing?
Adds
.exe
to the Javy and function-runner binary names on Windows.How to test your changes?
If you're on Windows, using cmd:
pnpm shopify app build --path <path_to_app>
will perform the initial download of Javy.pnpm shopify app build --path <path_to_app>
will test that it uses the downloaded version of Javy.echo {} | pnpm shopify app function run --path <path_to_js_function_extension>
will test the initial download of function-runner.echo {} | pnpm shopify app function run --path <path_to_js_function_extension>
will it uses the downloaded version of function-runner.Measuring impact
How do we know this change was effective? Please choose one:
Checklist