Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow managed stores for collaborators #4365

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

Collaborators can't see the list of stores they have access to from the CLI, but they can actually use them by passing --store or by updating the dev_store_url in the TOML.

Partners shows the managed store:
Monosnap Shopify Partners 2024-08-22 14-05-08

The CLI doesn't allow to choose it:
Monosnap node 2024-08-22 14-08-20

WHAT is this pull request doing?

Include the managed type in the filter for the stores, so that they appear in the CLI prompt.

How to test your changes?

  • Request access to a store from another partner account, and accept it
  • p shopify app dev

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.86% (+0.11% 🔼)
8275/11358
🟡 Branches
69.49% (+0.05% 🔼)
4042/5817
🟡 Functions
71.61% (+0.03% 🔼)
2157/3012
🟡 Lines
73.2% (+0.11% 🔼)
7828/10694
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / dev-stores-by-org.ts
100% 100% 100% 100%

Test suite run success

1859 tests passing in 846 suites.

Report generated by 🧪jest coverage report action from 34d0558

@gonzaloriestra gonzaloriestra marked this pull request as ready for review August 22, 2024 15:59
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@gonzaloriestra
Copy link
Contributor Author

@shauns your new lint rule worked as expected and forced me to migrate the GraphQL query 😅

Could you have a look at this commit to ensure it's right? I've checked that it works, but it's the first time I play with this.

@gonzaloriestra
Copy link
Contributor Author

@shaun I'm merging because I'm pretty sure the change is right, but please have a look when you have time, just in case.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 30, 2024
@gonzaloriestra gonzaloriestra removed this pull request from the merge queue due to a manual request Aug 30, 2024
@gonzaloriestra gonzaloriestra changed the base branch from main to stable/3.66 August 30, 2024 14:42
@gonzaloriestra gonzaloriestra changed the base branch from stable/3.66 to main August 30, 2024 14:43
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Aug 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2024
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 96db913 Sep 10, 2024
36 checks passed
@gonzaloriestra gonzaloriestra deleted the allow-managed-stores branch September 10, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants