[Themes] Theme Dev - Do not display warnings when file deletion fails

[jamesmengo]

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-advanced-edits/issues/310

The goals of this task are:
Update the logic so the file system module doesn't attempt to delete a non-existent file.
Change the logging approach from renderWarning to outputDebug since users cannot take any action on this issue.

WHAT is this pull request doing?

- Prevents the watcher from attempting to delete files that don't exist on the local theme

• outputDebug when the file deletion fails (either due to server error or because the file already doesn't exist)

How to test your changes?

Setup:

1. Create a theme with missing files -> shopify theme push -d -> delete files from the code editor
2. Execute shopify-dev theme dev --dev-preview --theme-editor-sync --verbose
3. Select 'delete files from local theme'
4. Check for verbose logs. You should see logs like: Failed to delete file "${fileKey}" from remote theme.

BEFORE

AFTER

Visual.Studio.Code.-.Dawn.mp4

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	73%	8389/11491
🟡	Branches	69.56%	4091/5881
🟡	Functions	71.75%	2179/3037
🟡	Lines	73.35%	7938/10822

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / ConcurrentOutput.tsx	98.39% (-1.61% 🔻)	90.91% (-4.55% 🔻)	100%	98.33% (-1.67% 🔻)

Test suite run success

1889 tests passing in 857 suites.

Report generated by 🧪jest coverage report action from d9691b8

[jamesmengo]

I'm debating whether we should make this call explicitly, or just call deleteThemeAsset (which will fail) and handle the failures silently.

This would save an additional call every time a file is deleted, but the tradeoff with that approach would mean that we are unable to discern between legitimate failures of deleteThemeAsset (such as a server failure) from instances where the failure comes from the asset not existing on the remote theme.

---

Update:
We landed on handling the failures silently rather than adding additional calls to check for file existence on the remote theme

This PR will prevent these calls being made in the first place

[github-actions]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

[frandiox]

Thanks for also adding the test!

[frandiox]

FYI there's also vi.waitFor in Vitest to deal with async code, but I think the promise here is actually better 👍