Add support for contract-based app modules #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success1890 tests passing in 858 suites. Report generated by 🧪jest coverage report action from c0478b4 |
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
reemrazak
approved these changes
Sep 19, 2024
reemrazak
reviewed
Sep 30, 2024
| ...field, | ||
| // NOTE: we're not using this id anywhere, generating it to satisfy the schema | ||
| // decided not to remove it from the schema for now to minimize the risk of breaking changes | ||
| id: randomUUID(), |
There was a problem hiding this comment.
is there an alternative way for us to generate this id in CLI since it's been removed here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We need to support app modules that define their schema using contracts. We already had this for
data, but that solution only supported config-extensions (defined in the app.toml).This solution adds support for contract-based non-config modules.
WHAT is this pull request doing?
Add a new
createContractBasedModuleSpecificationto easily generate this kind of specifications.Apply it to marketing activity extension and remove the custom config for it.
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist