Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.67] - Account for empty assets when calculating theme asset size #4484

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo self-assigned this Sep 19, 2024
@jamesmengo jamesmengo changed the base branch from main to stable/3.67 September 19, 2024 17:25
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73% (+0% 🔼)
8389/11491
🟡 Branches
69.55% (+0.01% 🔼)
4091/5882
🟡 Functions 71.75% 2179/3037
🟡 Lines
73.35% (+0% 🔼)
7938/10822
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / context.ts
91.67% (-0.03% 🔻)
87.28% 88.57%
92.62% (-0.03% 🔻)
🟡
... / factories.ts
57.89%
40% (-2.86% 🔻)
80% 68.75%

Test suite run success

1889 tests passing in 857 suites.

Report generated by 🧪jest coverage report action from d3b7162

@jamesmengo jamesmengo merged commit 8410e97 into stable/3.67 Sep 19, 2024
37 checks passed
@jamesmengo jamesmengo deleted the jm/bp-4475 branch September 19, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't pull theme anymore
2 participants