Make shopify theme dev more resilient to HTTP errors with the Admin API
#4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1943 tests passing in 876 suites. Report generated by 🧪jest coverage report action from 707b901 |
|
🚀 Thank you! This looks great. I left a quick question about the retry time |
EvilGenius13
reviewed
Oct 9, 2024
2 tasks
frandiox
approved these changes
Oct 10, 2024
EvilGenius13
approved these changes
Oct 18, 2024
|
@Shopify/app-inner-loop Could you please review this PR?(this is important to the next minor release, and it seems like the auto-merge is not working). Thank you! |
shauns
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to #4576, #4598, and #4599
Retry requests for some HTTP errors. This PR doesn't propose to refresh the session because we're already refreshing it every 30 minutes, the Admin session token expires in 2 hours, and we're getting a fresh token when we start the session.
WHAT is this pull request doing?
This PR updates the Admin REST API client to retry requests when they encounter certain HTTP errors. The Ruby CLI was more permissive regarding execution abortion, so we're adopting this approach as a middle-term to: fail when errors really happen but also be resilient and retry in some scenarios.
How to test your changes?
shopify theme push -de806941bd7538a0325593da4c02663c599f18e64in your local CLI (it will trigger an error every time we update a file)layout/theme.liquidfileshopify theme push -d --verbosePost-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist