Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify v8 of pnpm is required, as v9 is not supported yet #4754

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

edhgoose
Copy link
Contributor

As per #4467 (comment), v8 is required.

WHY are these changes introduced?

#4467 (comment) says that v8 of pnpm is required. I struggled with this bug until accidentally stumbling across the issue. The clarification would be helpful.

Fixes #0000

WHAT is this pull request doing?

Clarifying the docs for getting started locally.

How to test your changes?

Follow the instructions, with pnpm v9 installed. Confirm you get the error in the linked issue.

Downgrade to v8, confirm pnpm install works.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@edhgoose edhgoose requested a review from a team as a code owner October 26, 2024 10:24
@edhgoose
Copy link
Contributor Author

I've signed the CLA now

@isaacroldan isaacroldan merged commit 83ae4bf into Shopify:main Oct 28, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants