Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test JSON narrowing #4840

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Test JSON narrowing #4840

merged 1 commit into from
Nov 12, 2024

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Nov 12, 2024

WHY are these changes introduced?

Adds test coverage for JSON type narrowing functionality to ensure proper validation of string map objects. This module was low on coverage.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

shauns commented Nov 12, 2024

@shauns shauns marked this pull request as ready for review November 12, 2024 16:32
@shauns shauns requested a review from a team as a code owner November 12, 2024 16:32
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.70.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.69.0";
\ No newline at end of file

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.53% (+0.11% 🔼)
8464/11670
🟡 Branches
69.13% (+0.12% 🔼)
4109/5944
🟡 Functions
72.15% (+0.19% 🔼)
2225/3084
🟡 Lines
73.02% (+0.1% 🔼)
8004/10962

Test suite run success

1926 tests passing in 877 suites.

Report generated by 🧪jest coverage report action from 4ecff71

Copy link
Contributor Author

shauns commented Nov 12, 2024

Merge activity

  • Nov 12, 11:57 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 12, 12:08 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 12, 12:16 PM EST: A user merged this pull request with Graphite.

@shauns shauns changed the base branch from 11-12-test_tunnel_provider_plugin to graphite-base/4840 November 12, 2024 16:58
@shauns shauns changed the base branch from graphite-base/4840 to main November 12, 2024 17:05
@shauns shauns merged commit 13f7bb2 into main Nov 12, 2024
28 checks passed
@shauns shauns deleted the 11-12-test_json_narrowing branch November 12, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants