Remove PHP template from CLI #4843
Open
+13
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
shauns
requested changes
Nov 12, 2024
| @@ -33,9 +33,8 @@ export default class Dev extends AppCommand { | |||
| - Serving [GraphiQL for the Admin API](https://shopify.dev/docs/apps/tools/graphiql-admin-api#use-a-local-graphiql-instance) using your app's credentials and access scopes. | |||
| - Building and serving your app and app extensions. | |||
| If you're using the PHP or Ruby app template, then you need to complete the following steps before you can preview your app for the first time: | |||
| If you're using the Ruby app template, then you need to complete the following steps before you can preview your app for the first time: | |||
There was a problem hiding this comment.
Maybe this and the bullet point below can be merged together now.
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1917 tests passing in 870 suites. Report generated by 🧪jest coverage report action from 8554d02 |
lizkenyon
force-pushed
the
liz/remove-php-template
branch
from
ba0665d
to
551fe3e
Compare
lizkenyon
commented
Nov 12, 2024
Update review comments typo
lizkenyon
force-pushed
the
liz/remove-php-template
branch
from
551fe3e
to
93d65a6
Compare
lizkenyon
commented
Nov 12, 2024
packages/cli/README.md
Outdated
| @@ -259,10 +259,9 @@ DESCRIPTION | |||
| and access scopes. | |||
| - Building and serving your app and app extensions. | |||
| If you're using the PHP or Ruby app template, then you need to complete the following steps before you can preview | |||
| If you're using the Ruby app template, then you need to complete the following steps before you can preview | |||
There was a problem hiding this comment.
QQ: Is this readme generated from somewhere? Seems to be from dev.ts
There was a problem hiding this comment.
It is. I think CI checks will nudge you to do this but pnpm refresh-readme should do the job.
lizkenyon
force-pushed
the
liz/remove-php-template
branch
from
63b8e43
to
8554d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
WHAT is this pull request doing?
Before
After
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist