Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graphiql variables query param #5161

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jgray7019
Copy link
Contributor

@jgray7019 jgray7019 commented Jan 7, 2025

WHY are these changes introduced?

Part of https://github.com/Shopify/shopify-dev/issues/50532

Following up from #3345 where the query param support was implemented it would also be great it if we supported the variables query param that the GraphiQL explorer also supports. Example: https://graphql.github.io/swapi-graphql/?variables=variables

WHAT is this pull request doing?

Forwards the variables query param if present

How to test your changes?

  • Run app dev
  • Press g
  • Nothing should change
  • Add ?variables=test to the url in the browser and refresh
  • There should be a new tab with the variables
  • query params should still work
Screenshot 2025-01-07 at 10 44 27 AM

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@jgray7019 jgray7019 requested review from a team as code owners January 7, 2025 15:44
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.29% (+0.07% 🔼)
8841/11742
🟡 Branches
70.56% (+0.09% 🔼)
4290/6080
🟡 Functions
75.19% (+0.04% 🔼)
2315/3079
🟡 Lines
75.84% (+0.07% 🔼)
8358/11021
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% 90.48% 98.61%
🔴
... / server.ts
1.25% (-0.03% 🔻)
0% 0%
1.32% (-0.04% 🔻)
🔴
... / api.ts
56.29% (-3.01% 🔻)
43.59% (-1.53% 🔻)
57.5% (-2.5% 🔻)
57.59% (-3.14% 🔻)

Test suite run success

1994 tests passing in 902 suites.

Report generated by 🧪jest coverage report action from 2d92db7

@jgray7019 jgray7019 added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
@jgray7019 jgray7019 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 2b395c6 Jan 7, 2025
27 checks passed
@jgray7019 jgray7019 deleted the support-graphiql-variable-param branch January 7, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants