-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsx-transform support to extensions build #577
Add jsx-transform support to extensions build #577
Conversation
We detected some changes at packages/*/src and there are no updates in the .changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 'd with development store, works great! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! I tophatted this as well by deploying to my prod development store.
22ea3ca
to
b02e2ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this!
Trying to resolve this issue
This is my first PR here, if the fix is not enough/wrong feel free to direct me to the proper way to handle it.
WHY are these changes introduced?
React 17 has support for jsx without explicit React import, we want to have the same experience when building checkout extensions
WHAT is this pull request doing?
Added
automatic
option foresbuild
options, to allow auto import of ReactMore details: https://esbuild.github.io/api/#jsx
How to test your changes?
typescript-react
templatetsconfig.json
file is generatedReact not defined
error in your consoleMeasuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.