Change windowsHide to false #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
pepicrft
reviewed
Dec 9, 2022
| @@ -68,6 +68,7 @@ const buildExec = (command: string, args: string[], options?: ExecOptions): Exec | |||
| stdin: options?.stdin, | |||
There was a problem hiding this comment.
I'd adjust this one to options?.stdin ?? 'inherited'
There was a problem hiding this comment.
I tried this, but running dev quits unexpectedly after showing the logs. I suspect there is some issue with the ruby executable being run with this. Perhaps something for another PR?
pepicrft
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Tophatted and works as expected. Brilliant finding here @matteodepalo
matteodepalo
force-pushed
the
change-windowshide
branch
from
eba2aca
to
ca8141b
Compare
Coverage report
Test suite run success417 tests passing in 238 suites. Report generated by 🧪jest coverage report action from ca8141b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #630
On Windows, processes are left hanging around after users terminate
devwithCtrl+C. Digging around I found an issue open on theexecarepo that mentioned issues withSIGINTand child processes not getting killed properly on Windows ifwindowsHideis left to its default value oftrue.WHAT is this pull request doing?
This PR changes the value of
windowsHidefrom its default oftruetofalse. This did not seem to have any effect on the behavior ofdevHow to test your changes?
yarn shopify app dev --path fixtures/appon WindowsCtrl+Cand see all the node processes disappear.There will be 1 node process remaining, but this behavior also happens on Mac and there we haven't had any problems with cleaning up child processes. If that single process becomes a problem we can investigate further, but for now this change should make the two platforms behave the same.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.