Skip to content

Merge pull request #5234 from Shopify/revert-5020-fetch-notifications…

Sign in for the full log view
GitHub Actions / ESLint Report Analysis succeeded Jan 20, 2025 in 2s

ESLint Report Analysis

0 ESLint error(s) and 150 ESLint warning(s) found

Details

Annotations

Check warning on line 83 in packages/app/src/cli/commands/app/deploy.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/commands/app/deploy.ts#L83

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 65 in packages/app/src/cli/services/flow/validation.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/flow/validation.ts#L65

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 139 in packages/app/src/cli/commands/app/dev.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/commands/app/dev.ts#L139

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 75 in packages/cli-kit/src/public/node/analytics.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/cli-kit/src/public/node/analytics.ts#L75

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 115 in packages/app/src/cli/services/flow/validation.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/flow/validation.ts#L115

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 59 in packages/app/src/cli/commands/app/function/run.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/commands/app/function/run.ts#L59

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 81 in packages/cli-kit/src/public/node/analytics.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/cli-kit/src/public/node/analytics.ts#L81

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 366 in packages/app/src/cli/services/function/build.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/function/build.ts#L366

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 50 in packages/cli-kit/src/public/node/base-command.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/cli-kit/src/public/node/base-command.ts#L50

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 67 in packages/app/src/cli/commands/app/function/run.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/commands/app/function/run.ts#L67

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 95 in packages/app/src/cli/services/generate.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate.ts#L95

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 109 in packages/app/src/cli/commands/app/webhook/trigger.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/commands/app/webhook/trigger.ts#L109

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 155 in packages/cli-kit/src/public/node/base-command.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/cli-kit/src/public/node/base-command.ts#L155

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 85 in packages/app/src/cli/services/generate/extension.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/extension.ts#L85

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 99 in packages/cli-kit/src/public/node/dot-env.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/cli-kit/src/public/node/dot-env.ts#L99

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 243 in packages/app/src/cli/models/app/app.test.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/models/app/app.test.ts#L243

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 130 in packages/cli-kit/src/public/node/error-handler.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/cli-kit/src/public/node/error-handler.ts#L130

[@typescript-eslint/prefer-promise-reject-errors] Expected the Promise rejection reason to be an Error.

Check warning on line 177 in packages/app/src/cli/services/generate/extension.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/generate/extension.ts#L177

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 245 in packages/app/src/cli/models/app/app.test.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/models/app/app.test.ts#L245

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 272 in packages/cli-kit/src/public/node/git.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/cli-kit/src/public/node/git.ts#L272

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 267 in packages/app/src/cli/models/extensions/extension-instance.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/models/extensions/extension-instance.ts#L267

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 19 in packages/app/src/cli/services/init/template/npm.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/init/template/npm.ts#L19

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 297 in packages/cli-kit/src/public/node/git.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/cli-kit/src/public/node/git.ts#L297

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 80 in packages/app/src/cli/models/extensions/specifications/app_config_privacy_compliance_webhooks.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/models/extensions/specifications/app_config_privacy_compliance_webhooks.ts#L80

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 55 in packages/app/src/cli/services/payments/extension-to-toml.ts

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/app/src/cli/services/payments/extension-to-toml.ts#L55

[@typescript-eslint/prefer-nullish-coalescing] Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.