Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initialization instructions for load path hashes #28

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

mclark
Copy link
Contributor

@mclark mclark commented Apr 1, 2022

#27 overlooked adding documentation to the README for load path hashes. This PR tidies up that loose end 😄

@@ -36,6 +36,19 @@ resolver = ConstantResolver.new(
)
```

If any load paths have a default namespace other than `Object`, these can be specified in a hash:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nitpicking now but I think "default namespaces" would be a good headline for this part

@exterm exterm merged commit 0473c46 into Shopify:master Apr 1, 2022
@mclark mclark deleted the docs-for-non-default-namespace branch April 1, 2022 17:23
@shopify-shipit shopify-shipit bot temporarily deployed to production April 1, 2022 17:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants