Fix cart improvements empty state #319

tauthomas01 · 2021-08-04T18:36:12Z

Why are these changes introduced?

Fixes #314

The goal of this PR is to improve the empty state of the cart.

What approach did you take?

Adjust CSS spacing
Add Liquid text and login link

Demo links

Store
Editor

Checklist

martinamarien

Looks good on my end Thomas. I'd recommend we request translations now if content is confirmed so that they come in soon 🤞🏻

templates/cart.json

martinamarien · 2021-08-04T19:32:31Z

sections/main-cart-items.liquid

+    {%- if shop.customer_accounts_enabled -%}
+      <h3 class="cart__login-title">{{ 'sections.cart.login.title' | t }}</h3>
+      <p class="cart__login-paragraph">
+        {{ 'sections.cart.login.paragraph_html' | t: link: routes.account_login_url }}
+      </p>
+    {%- endif -%}


Is this only meant to be visible on the empty cart state?
If it allows you to checkout faster, shouldn't we surface this to customer with items in their cart as well?

Yeah, this is empty state only. It's an interesting point, though.

cc. @melissaperreault if you have time to see Martina's question.

This is a good question, I'll investigate with the team and come back! 👍

locales/en.default.json

tyleralsbury

Looks good overall. One question, can we default the featured collection to the all_products collection? I think that should be possible. It would allow for merchants to not need to make any changes for it to already look good in the cart.

locales/en.default.json

martinamarien · 2021-08-04T20:55:36Z

I added a comment regarding that I am unsure if it's possible to display all products. Usually, we need to use an existing collection.

I wonder if we should do this if this is the only place we are doing something like this on the theme.

tyleralsbury · 2021-08-04T21:08:26Z

I added a comment regarding that I am unsure if it's possible to display all products. Usually, we need to use an existing collection.

I wonder if we should do this if this is the only place we are doing something like this on the theme.

We can see with @Guillaumegranger1 but the rationale was basically that this is a part of the theme the merchant might not actually check when setting up their store, compared to something like the homepage, so we should have a default that makes sense.

If "all products" isn't possible, maybe we can default it to their first collection, whatever that is? Not sure if that works or not. 🤔

tauthomas01 · 2021-08-05T01:51:18Z

If "all products" isn't possible, maybe we can default it to their first collection, whatever that is? Not sure if that works or not.

Usually, we use the frontpage (homepage) collection, but os2-demo removed it so I am not sure if it's reliable.

I tried all_products but it doesn't seem to work.

tauthomas01 · 2021-08-05T14:27:53Z

Update: I found out all is a value to display all collection by default, thanks to Sofia and Martina!

… default state

sections/main-cart-items.liquid

assets/component-cart.css

locales/en.default.json

assets/component-cart.css

tauthomas01 · 2021-08-05T21:27:35Z

Thank you for the review @melissaperreault ! Just made the changes

martinamarien

Looks good Thomas. All translations are back too 🙌🏻

tyleralsbury

Looks awesome.

tyleralsbury · 2021-08-09T13:34:19Z

templates/cart.json

  ]
-}
+}


Suggested change

}

}

Feel free to keep this so that the approvals don't get removed. Just noting it.

assets/component-cart.css

melissaperreault

Once the little small spacing change are done, we are good to go! 🎉

* main: (23 commits) Cart content update (Shopify#370) Footer spacing and alignment adjustments (Shopify#369) Product Template UI polish updates (Shopify#219) footer ui updates (Shopify#318) Fix cart improvements empty state (Shopify#319) [Announcement] Adjust block id for displaying dynamic names (Shopify#327) Update translations: buyer (Shopify#329) Revert editor setting changes (Shopify#328) Update translations (Shopify#294) Fix collection filtering UX (Shopify#268) Added page width setting and fixed image quality (Shopify#292) Add top border on cart notification when "show separator line" setting is deactivated (Shopify#306) movebadge code into base.css (Shopify#313) Collage UI bug fixes (Shopify#308) Customer account UI polish (Shopify#177) Added custom liquid block to product page (Shopify#269) Fix disclosure icon (Shopify#310) Fix facet price filter label spacing (Shopify#300) Fix duplicate search icon when header logo is set to "Top center" (Shopify#252) Add card outline setting (Shopify#239) ...

* Fix cart improvements empty state * rename featured_products to feature-products * Add 'all' to show all products when displaying featured collection in default state * Update 3 translation files * add white space at end of line * Adjust heading hierarchy, and spacing * Update 21 translation files * Update 6 translation files * Spacing adjustment * adjust padding Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

tauthomas01 requested a review from melissaperreault August 4, 2021 18:41

martinamarien self-requested a review August 4, 2021 19:08

martinamarien previously approved these changes Aug 4, 2021

View reviewed changes

martinamarien reviewed Aug 4, 2021

View reviewed changes

locales/en.default.json Show resolved Hide resolved

tyleralsbury reviewed Aug 4, 2021

View reviewed changes

locales/en.default.json Show resolved Hide resolved

tauthomas01 dismissed martinamarien’s stale review via 435bb8b August 5, 2021 01:52

tauthomas01 mentioned this pull request Aug 5, 2021

Cart empty state enhancement #314

Closed

3 tasks

tauthomas01 and others added 4 commits August 5, 2021 11:22

Fix cart improvements empty state

0585e5d

rename featured_products to feature-products

1baef75

Add 'all' to show all products when displaying featured collection in…

1acc5a5

… default state

Update 3 translation files

46b1d2e

tauthomas01 force-pushed the fix-cart-improvements branch from fbfa513 to 46b1d2e Compare August 5, 2021 15:22

add white space at end of line

0c1e299

svinkle reviewed Aug 5, 2021

View reviewed changes

sections/main-cart-items.liquid Outdated Show resolved Hide resolved

svinkle reviewed Aug 5, 2021

View reviewed changes

sections/main-cart-items.liquid Outdated Show resolved Hide resolved

melissaperreault reviewed Aug 5, 2021

View reviewed changes

assets/component-cart.css Outdated Show resolved Hide resolved

melissaperreault reviewed Aug 5, 2021

View reviewed changes

locales/en.default.json Outdated Show resolved Hide resolved

melissaperreault reviewed Aug 5, 2021

View reviewed changes

assets/component-cart.css Outdated Show resolved Hide resolved

Adjust heading hierarchy, and spacing

d2fda82

tauthomas01 requested a review from melissaperreault August 5, 2021 21:24

tauthomas01 requested a review from martinamarien August 5, 2021 21:27

translation-platform bot added 2 commits August 6, 2021 15:00

Update 21 translation files

48915fb

Update 6 translation files

0a5e364

martinamarien previously approved these changes Aug 8, 2021

View reviewed changes

tyleralsbury previously approved these changes Aug 9, 2021

View reviewed changes

melissaperreault reviewed Aug 9, 2021

View reviewed changes

assets/component-cart.css Show resolved Hide resolved

melissaperreault self-requested a review August 9, 2021 17:04

melissaperreault previously approved these changes Aug 9, 2021

View reviewed changes

Spacing adjustment

10b0abb

tauthomas01 dismissed stale reviews from melissaperreault, tyleralsbury, and martinamarien via 10b0abb August 9, 2021 17:19

adjust padding

f409ef2

melissaperreault approved these changes Aug 9, 2021

View reviewed changes

tyleralsbury approved these changes Aug 9, 2021

View reviewed changes

tauthomas01 merged commit eaa5621 into main Aug 9, 2021

tauthomas01 deleted the fix-cart-improvements branch August 9, 2021 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix cart improvements empty state #319

Fix cart improvements empty state #319

tauthomas01 commented Aug 4, 2021 •

edited

Loading

martinamarien left a comment

martinamarien Aug 4, 2021

tyleralsbury Aug 4, 2021

tauthomas01 Aug 5, 2021

melissaperreault Aug 5, 2021

tyleralsbury left a comment

martinamarien commented Aug 4, 2021

tyleralsbury commented Aug 4, 2021

tauthomas01 commented Aug 5, 2021 •

edited

Loading

tauthomas01 commented Aug 5, 2021

tauthomas01 commented Aug 5, 2021

martinamarien left a comment

tyleralsbury left a comment

tyleralsbury Aug 9, 2021

tyleralsbury Aug 9, 2021

melissaperreault left a comment

Fix cart improvements empty state #319

Fix cart improvements empty state #319

Conversation

tauthomas01 commented Aug 4, 2021 • edited Loading

martinamarien left a comment

Choose a reason for hiding this comment

martinamarien Aug 4, 2021

Choose a reason for hiding this comment

tyleralsbury Aug 4, 2021

Choose a reason for hiding this comment

tauthomas01 Aug 5, 2021

Choose a reason for hiding this comment

melissaperreault Aug 5, 2021

Choose a reason for hiding this comment

tyleralsbury left a comment

Choose a reason for hiding this comment

martinamarien commented Aug 4, 2021

tyleralsbury commented Aug 4, 2021

tauthomas01 commented Aug 5, 2021 • edited Loading

tauthomas01 commented Aug 5, 2021

tauthomas01 commented Aug 5, 2021

martinamarien left a comment

Choose a reason for hiding this comment

tyleralsbury left a comment

Choose a reason for hiding this comment

tyleralsbury Aug 9, 2021

Choose a reason for hiding this comment

tyleralsbury Aug 9, 2021

Choose a reason for hiding this comment

melissaperreault left a comment

Choose a reason for hiding this comment

tauthomas01 commented Aug 4, 2021 •

edited

Loading

tauthomas01 commented Aug 5, 2021 •

edited

Loading