Change disclosure list width for country/currency selector #3631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenekasimov
changed the title
eugenekasimov
commented
Sep 27, 2024
| @@ -148,7 +148,7 @@ | |||
| max-height: 20.5rem; | |||
| max-width: 25.5rem; | |||
| min-width: 12rem; | |||
| width: 100%; | |||
| width: max-content; | |||
There was a problem hiding this comment.
From my understanding this should have an impact only on a list when currency code is not rendered. Otherwise,
.country-selector__list--with-multiple-currencies {
width: 25.5rem;
}
this 👆 applied.
melissaperreault
approved these changes
Sep 27, 2024
tyleralsbury
approved these changes
Sep 27, 2024
eugenekasimov
deleted the
euegen/fix-currency-list-width-for-no-currency-code
branch
NathanScheele
pushed a commit
to Misha-Puff/dawn
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
The country selector dropdown will put long country names with multiple words, like "United States" or "United Kingdom" on two lines instead of one line. This happens in case when a store has the same currency for different markets, so the currency code is not rendered on a list. The PR fixes it.
Before
After
Other considerations
Let's be careful with this. it was changed the way it is now for a reason. However, I could find any side effect for now.
Testing steps/scenarios
Demo links
Checklist