-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL versions & test against newer ones #58
Conversation
This failure seems to occur on only the Active Support 7.0 CI runs, but be fixed in the edge runs.
Using
Based on that, we must have a usage of an Active Support internal file without |
The issue is that #50 added
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update and nice cleanup! I learned a few tricks for managing several versioned gemfiles.
CHANGELOG.md
Outdated
* [#58](https://github.com/Shopify/deprecation_toolkit/pull/58): Drop support for Ruby < 2.6 & Active Support < 5.2. (@sambostock) | ||
* [#58](https://github.com/Shopify/deprecation_toolkit/pull/58): `require 'active_support'` earlier to ensure compatibility with v7. (@sambostock) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only documented the user facing changes. Excluded are:
- the changes to CI infrastructure
- the changes to development dependency versions and config
The rake task code requires a subset of Active Support, but doing this without having first required the main gem entry point is not supported and breaks in 7.0
We aren't using groups, so we can take a simpler approach by keeping runtime dependencies in the gemspec, and everything else in Gemfile. We can also use eval_gemfile to avoid repeating ourselves. Instance variable approach based on Shopify/maintenance_tasks.
The most important changes made in this PR are that it drops support for the following:
Note than 2.6 EOL is scheduled for 31 Mar 2022
Several related changes are made:
rails/rail:main
)