Add insertBy option to allow prepending or appending elements
#514
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements or fixes
This PR allows the user to specify whether they'd like the dragged element to be prepended or appended to the container.
I have a use-case where I need to add the element to the top of a scrollable list of elements, so adding it to the bottom causes it to be below the fold and hence the user can't see it.
Does this PR require the Docs to be updated?
Yes, and I've done so (hope they're appropriate).
Does this PR require new tests?
Yes, I've added a default option and added a test for that to ensure backwards compatibility, but it could do with another test to check it actually works. I wasn't able to quickly find a way of doing that, any pointers would be appreciated.
This branch been tested on... (click all that apply / add new items)
Browsers: