Jake Spodek's Stopwatch #357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added some basic structural elements
added basic functions to the start and reset buttons and passed them as props to the button components
added some basic temporary styling
added a stop button and changed the start/stop button to just a start button
Switched to using useRef instead of useState for managing the time
Added formatTime function to properly format the data displayed on the stopwatch and changed the StopWatch.tsx time prop's type to string
changed some double-quotes to single-quotes
improved formatting/indentation
Added some semicolons
partial lap time functionality
added the three stopwatch states and logic for disabling buttons depending on the stopwatch state
Added comments
set up testing file and passed first necessary test
fixed webpack/jest/css import issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my completed stopwatch app for the intern assessment.
This was my first time using TypeScript and my first time writing tests but I am quite happy with my app's functionality, code quality, and documentation (and UI design).
It would be great to know what my app's greatest areas for improvement are, especially with regards to testing.