Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement file cache #268

Merged
merged 23 commits into from
Oct 26, 2022
Merged

[Feature] Implement file cache #268

merged 23 commits into from
Oct 26, 2022

Commits on Aug 30, 2022

  1. Implement file cache 

    First approach to implement a file cache.

Shopify#158

Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
    @ChrisBr @flavorjones @zachfeldman
    2 people authored and zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    fbf26a2 View commit details
    Browse the repository at this point in the history

  2. Initial cleaning implementation

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    17ce887 View commit details
    Browse the repository at this point in the history

  3. Rename clean to prune, implement clearing, add autocorrect error message

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    b5aeb01 View commit details
    Browse the repository at this point in the history

  4. Lints and cops

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    95b5e22 View commit details
    Browse the repository at this point in the history

  5. Add integration specs

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    7032a73 View commit details
    Browse the repository at this point in the history

  6. Fix cache implementation, clean up code

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    6012ae8 View commit details
    Browse the repository at this point in the history

  7. Specs for cache and associated changes

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    ad47b98 View commit details
    Browse the repository at this point in the history

  8. Clean up

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    fbbcd2a View commit details
    Browse the repository at this point in the history

  9. Include ERBLint version in cache key

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    a292ef0 View commit details
    Browse the repository at this point in the history

  10. Fix nonsensical error message

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    be11370 View commit details
    Browse the repository at this point in the history

  11. Spacing fixes and removing unneeded code

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    deeb4f8 View commit details
    Browse the repository at this point in the history

  12. Fix tests by mocking returned checksum

    @zachfeldman
    zachfeldman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    1a5db05 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Move cache pruning to the cache class

    @zachfeldman
    zachfeldman committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    8d4eaa8 View commit details
    Browse the repository at this point in the history

  2. Do less file reads and stats

    @zachfeldman
    zachfeldman committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    cdf089c View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Attempt a new implementation for storing offenses in a CachedOffense … 

    …for speed
    @zachfeldman
    zachfeldman committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    b331799 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Update lib/erb_lint/cached_offense.rb to avoid errors on nil severity 

    Co-authored-by: Eric Terry <eterry1388@aol.com>
    @zachfeldman @eterry1388
    zachfeldman and eterry1388 authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    ce8d6da View commit details
    Browse the repository at this point in the history

  2. Support caching with json and compact reporters

    @eterry1388
    eterry1388 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    acba4a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Merge pull request #1 from eterry1388/eterry1388/zfeldman/cbruckmayer… 

    …/implement-file-cache

Support caching with json and compact reporters
    @zachfeldman
    zachfeldman authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    6d492e4 View commit details
    Browse the repository at this point in the history

  2. Update lib/erb_lint/cli.rb to use safe navigation operator 

    Co-authored-by: Étienne Barrié <etienne.barrie@gmail.com>
    @zachfeldman @etiennebarrie
    zachfeldman and etiennebarrie authored Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9ec34e3 View commit details
    Browse the repository at this point in the history

  3. Rename with-cache to cache

    @zachfeldman
    zachfeldman committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    877c28c View commit details
    Browse the repository at this point in the history

  4. Prune cache by default

    @zachfeldman
    zachfeldman committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7ea048c View commit details
    Browse the repository at this point in the history

  5. Add README for cache

    @zachfeldman
    zachfeldman committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    a32816d View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Reduce output of pruning process

    @zachfeldman
    zachfeldman committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    e082855 View commit details
    Browse the repository at this point in the history