Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom cache directory via --cache-dir option #282

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

adrianna-chang-shopify
Copy link

Motivation

Follow up to: #268 (comment)

As discussed in the prior PR, it would be nice to be able to specify the cache directory like you can do with Rubocop.

Co-authored-by: Étienne Barrié <etienne.barrie@shopify.com>
Co-authored-by: Étienne Barrié <etienne.barrie@shopify.com>
Copy link

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I don't have the highest erb-lint context but this PR looks clear to me. 🙌

@adrianna-chang-shopify adrianna-chang-shopify merged commit 3deee16 into main Oct 27, 2022
@adrianna-chang-shopify adrianna-chang-shopify deleted the ac-move-cached-dir branch October 27, 2022 13:42
@zachfeldman
Copy link

Nice @adrianna-chang-shopify and @etiennebarrie ! Since this is now in, will a release be cut soon? Sorry if I missed that somewhere.

@adrianna-chang-shopify
Copy link
Author

adrianna-chang-shopify commented Oct 31, 2022

Hey @zachfeldman , I can get a release cut today (EDIT: sorry, today was a bit ambitious, I'll make time this week for sure though)!

@shopify-shipit shopify-shipit bot temporarily deployed to production November 1, 2022 16:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants