Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve autocorrect deprecations #378

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Resolve autocorrect deprecations #378

wants to merge 3 commits into from
+25 −171

Commits on Sep 18, 2024

  1. Remove Ruby <= 2.5 compatibility code 

    The gemspec dictates Ruby >= 2.7
    @Earlopain
    Earlopain committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4ec6a7d View commit details
    Browse the repository at this point in the history

  2. Remove pre-RuboCop v1 compatibility code 

    Gemspec now requires >= 1.0, so this is just dead code
    @Earlopain
    Earlopain committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    48ffca8 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Don't use deprecated corrector apis 

    Closes Shopify#368

This is pretty much just a compatibility layer in itself.

Cops here are still declared with the old style (`autocorrect` instance method for example)
but rewriting that all is not trivial and also works just fine
    @Earlopain
    Earlopain committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7fddf50 View commit details
    Browse the repository at this point in the history