Update activesupport #394
Merged
Update activesupport #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewn617
approved these changes
Jan 13, 2025
|
Given this solution, what is your advice on how to run erb_lint in the context of a bundle with rails 7.0 and concurrent-ruby 1.3.5? |
|
If you add logger to your Gemfile, then concurrent-ruby will be able to find it in your bundle. |
|
It's not concurrent-ruby that needs to find it, it's activesupport. Even when logger is in the bundle, there's no code that requires it when running |
|
Oh right, the solution for now is to lock concurrent-ruby to 1.3.4 or to run FWIW the changes from this PR here didn't change the gem at all, just the development environment for the gem. To fix this, we could either depend on activesupport It's just that Active Support 7.0 is broken with concurrent-ruby 1.3.5:
|
|
Oh I forgot one workaround you might be able to use: $ bundle binstub erb_lint
$ ruby -pi -e 'print %(require "logger"\n) if /Gem\.bin_path/' -- bin/erb_lint
$ # replace all occurrences of `bundle exec erb_lint` with `bin/erb_lint`Not great, but until you can upgrade, that's probably the simplest. |
|
Thanks @etiennebarrie, I will try that workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #392, CI failed on ruby-head because
loggeris no longer part of the standard library.It could be added to Bundler, but instead I upgraded activesupport so that we are testing with Active Support 8.0. But it's incompatible with Ruby 3.1 so I also tweaked the CI scripts to use an older version there.