Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for known issues #1001

Closed
wants to merge 2 commits into from

Conversation

larsmunkholm
Copy link

Description

I have been having an issue with FlashList showing the "rendered size" warning when navigating away from a screen with a FlashList.

First I solved the issue by only rendering FlashList if the screen was in focus, but that caused it to disappear when opening modals and being reset when closing the modal.

I discovered that setting React Navigation's option animationEnabled to false caused the screen to be 0px in width and height before unmounting.

@markrickert
Copy link
Contributor

You need to sign the CLA

@larsmunkholm
Copy link
Author

I've signed the CLA!

@larsmunkholm
Copy link
Author

I don't think this PR has any effect on why the e2e check fails

@naqvitalha
Copy link
Collaborator

@larsmunkholm This PR may not be required with the latest improvements to the warning. Can you please check?

@larsmunkholm
Copy link
Author

larsmunkholm commented Mar 15, 2024

@larsmunkholm This PR may not be required with the latest improvements to the warning. Can you please check?

@naqvitalha Not sure what you want me to check. The Flash List package hasn't been updated since I made this PR.
I still get the same warning in RN with animationEnabled set to false
image

@naqvitalha
Copy link
Collaborator

@larsmunkholm We shipped FlashList v1.6.4 which improves this warning. The change was in main but the new package was released few days back.

@larsmunkholm
Copy link
Author

More than 2 months later, and I'm still getting warnings.
For anyone passing by, replace animationEnabled: false with

transitionSpec: {
    open: { animation: "timing", config: { duration: 0 } },
    close: { animation: "timing", config: { duration: 0 } },
},
cardStyleInterpolator: CardStyleInterpolators.forNoAnimation,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants