Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Canvas type missmatch in Android SDK 34 #930

Merged

Conversation

kassemitani
Copy link
Contributor

Description

Canvas type missmatch in Android SDK 34
Fixes (issue #864)

Fix by @siyahulhaq posted in issueComment

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)

Checklist

@kassemitani
Copy link
Contributor Author

I have signed the CLA!

@ahna92
Copy link

ahna92 commented Oct 17, 2023

any alpha/beta version we can use until this is merged ?

@RadicalRoy
Copy link

@ahna92 You can use patch-package to maintain the update as a post-install command.

Like my team is doing.

Please merge and release 🙏 ❤️

@kassemitani
Copy link
Contributor Author

@naqvitalha Can you look at this PR?

Copy link

@siyahulhaq siyahulhaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution will fix the issue

@naqvitalha
Copy link
Collaborator

Thanks for raising the PR!

@naqvitalha naqvitalha merged commit bd0af03 into Shopify:main Nov 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants