Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite delivery-customization with Remix #292

Merged
merged 7 commits into from
Jul 26, 2023

Conversation

May-Abo
Copy link
Contributor

@May-Abo May-Abo commented Jul 25, 2023

What are you trying to accomplish?

THIS WILL BE SHIPPED AT 7 AM EST ON JULY 26

Close this issue Delivery: Use Remix template for function app tutorial and sample app
Update the Delivery Customization app sample app to use Remix.

What approach did you choose and why?

dev clone delivery-customizations-app
npm install
npm run setup
npm run dev
npm run deploy 

@May-Abo May-Abo self-assigned this Jul 25, 2023
@May-Abo May-Abo force-pushed the delivery-customization-app-remix branch 2 times, most recently from 6ec23c0 to 96921aa Compare July 25, 2023 16:17
@May-Abo May-Abo marked this pull request as ready for review July 25, 2023 17:07
@May-Abo May-Abo changed the title Rewrite delivery-customization with Remix [DO NOT SHIP] Rewrite delivery-customization with Remix Jul 25, 2023
@May-Abo May-Abo force-pushed the delivery-customization-app-remix branch from faeb2ab to 2261dc6 Compare July 25, 2023 20:40
Copy link
Contributor

@andrewhassan andrewhassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩

@andrewhassan
Copy link
Contributor

The only issue I ran into is that the CLI doesn't like shopify.app.toml only having scopes in there. I had to delete the file for the dev to work.

@andrewhassan
Copy link
Contributor

Turns out it's not because the file exists, but it's because there's a space between scopes 🤦 I've pushed a commit with the fix.

@andrewhassan andrewhassan force-pushed the delivery-customization-app-remix branch from 6f5b341 to 7a18f20 Compare July 26, 2023 11:04
@andrewhassan andrewhassan force-pushed the delivery-customization-app-remix branch from 51201ff to 30eb238 Compare July 26, 2023 11:09
@andrewhassan andrewhassan merged commit 8d2acab into main Jul 26, 2023
4 checks passed
@May-Abo May-Abo changed the title [DO NOT SHIP] Rewrite delivery-customization with Remix Rewrite delivery-customization with Remix Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants