-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite delivery-customization with Remix #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May-Abo
force-pushed
the
delivery-customization-app-remix
branch
2 times, most recently
from
July 25, 2023 16:17
6ec23c0
to
96921aa
Compare
May-Abo
requested review from
andrewhassan,
nickwesselman,
mathieushopify and
davejcameron
July 25, 2023 17:07
May-Abo
changed the title
Rewrite delivery-customization with Remix
[DO NOT SHIP] Rewrite delivery-customization with Remix
Jul 25, 2023
May-Abo
force-pushed
the
delivery-customization-app-remix
branch
from
July 25, 2023 20:40
faeb2ab
to
2261dc6
Compare
andrewhassan
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩
The only issue I ran into is that the CLI doesn't like |
Turns out it's not because the file exists, but it's because there's a space between scopes 🤦 I've pushed a commit with the fix. |
andrewhassan
force-pushed
the
delivery-customization-app-remix
branch
from
July 26, 2023 11:04
6f5b341
to
7a18f20
Compare
andrewhassan
force-pushed
the
delivery-customization-app-remix
branch
from
July 26, 2023 11:09
51201ff
to
30eb238
Compare
May-Abo
changed the title
[DO NOT SHIP] Rewrite delivery-customization with Remix
Rewrite delivery-customization with Remix
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
THIS WILL BE SHIPPED AT 7 AM EST ON JULY 26
Close this issue Delivery: Use Remix template for function app tutorial and sample app
Update the Delivery Customization app sample app to use Remix.
What approach did you choose and why?
app.delivery-customization.$functionId.$id.jsx
authored-by: David Cameron @davejcameron