Update documentation for InlineVerifier and TargetVerifier #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuhaowu
approved these changes
May 4, 2020
docs/source/verifiers.rst
Outdated
| @@ -39,7 +39,7 @@ are given below: | |||
|
|
|||
| If you want verification, you should try with the ``ChecksumTableVerifier`` | |||
| first if you're copying whole tables at a time. If that takes too long, you can | |||
| try using the ``IterativeVerifier``. Alternatively, you can verify in a staging | |||
| try using the ``IterativeVerifier`` or ``InlineVerifier``. Alternatively, you can verify in a staging | |||
| run and not verify during the production run (see :ref:`copydbinprod`). | |||
|
|
|||
| IterativeVerifier | |||
There was a problem hiding this comment.
Can we add a line saying this is deprecated and will be removed.
fjordan
force-pushed
the
feature/update-docs-new-verifiers
branch
from
0fc647a to
66c3205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of the recent work done to add the
TargetVerifier. Also includes updates for theInlineVerifierin the documentation.The architecture diagram was modified to include the
BinlogWriter,TargetVerifier, andInlineVerifierloops. TheInlineVerificationstep was also added to theTableIteratorloop to display where in the processes the data is now verified as theInlineVerifieris now used in place of theIterativeVerifier.Updated the documentation the Verifiers with two new sections - one for the
InlineVerifierand another for theTargetVerifier.On what should reviewers focus?
Please read through the added written documentation and visual documentation to ensure they are both accurate and complete.
/cc @Shopify/pods