Patch go-mysql to keep trailing zero in floats in json #368
Conversation
mtaner
force-pushed
the
mt/patch-trailing-zero-json-serialisation
branch
from
579d72c to
41f382c
Compare
mtaner
changed the title
vendor/github.com/go-mysql-org/go-mysql/replication/json_binary.go
Outdated
Show resolved
Hide resolved
test/integration/types_test.rb
Outdated
| @@ -103,28 +106,33 @@ def test_json_data_insert | |||
| # with a JSON column is broken on 5.7. | |||
| # See: https://bugs.mysql.com/bug.php?id=87847 | |||
| res = target_db.query("SELECT COUNT(*) AS cnt FROM #{DEFAULT_FULL_TABLE_NAME}") | |||
| assert_equal 16, res.first["cnt"] | |||
| assert_equal ENV["MYSQL_VERSION"] == "8.0" ? 22 : 18, res.first["cnt"] # 22 rows with trailing zero data, 18 without trailing zero | |||
There was a problem hiding this comment.
Is there any other better way? checking and counting manually sounds not like a sustainable/maintainable solution here
There was a problem hiding this comment.
there is always a better way :D Let me have a look at it again now I have slept on it. I wanted to make it really obvious that system behaves differently for different mysql versions.
The other approach I considered is getting rid of the trailing 0 for 5.7 instead of this seperation - I will have a look at it again.
There was a problem hiding this comment.
98d4b92 - changes here I think its better?
There was a problem hiding this comment.
Is the plan to upstream this change? If we make patches to the vendored libraries, we have to make sure that they're not overwritten. 🤔
There was a problem hiding this comment.
If it is overwritten - the integration tests will start failing but the plan is to propose the upstream change to go-mysql and see what they say
mtaner
force-pushed
the
mt/patch-trailing-zero-json-serialisation
branch
from
0783bbd to
8086a46
Compare
mtaner
force-pushed
the
mt/patch-trailing-zero-json-serialisation
branch
from
8086a46 to
bda3785
Compare
Patched json binary decoder from go-mysql library to add a custom marshal json method for the floats to keep the trailing 0.
This patch only works with mysql version 8, as mysql version 5.7 gets rid of the trailing 0 on
.
cast...as jsonThis means that the tests added for checking that the trailing 0 is not dropped will fail for the 5.7 ruby tests so I have updated the test to ignore trailing 0 data for mysql version 5.7
Next steps are the open a PR with go-mysql highlighting that this will only work with mysql version 8 onwards (and add settings option similar to
useDecimaltoBinlogSyncerConfigand see what they think.