Add Ruby 3.0 to CI #135
Merged
Add Ruby 3.0 to CI #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eapache
reviewed
Jan 12, 2021
.github/workflows/ci.yml
Outdated
| @@ -9,8 +9,11 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ruby: [2.3, 2.6, 2.7] | |||
| graphql_version: ['1.9.19', '1.10.2'] | |||
| ruby: [2.3, 2.6, 2.7, 3.0] | |||
There was a problem hiding this comment.
If we're testing 2.3 and 3.0 now we probably don't need both 2.6 and 2.7 here
There was a problem hiding this comment.
🤷♂️ sure let's drop 2.6
|
I'm doing some tests with Ruby 3.0 rails Rails master here and it's not working... Are we doing some tests using rails here? |
|
This gem doesn't have any integration tests using Rails, but from looking at those failures, it's not actually Rails/DB related; just the Relay connections in the graphql gem. So while graphql-batch may technically work with Ruby 3.0, most consumers would probably run into trouble with the graphql gem itself (unless they don't use connections 🤷♂️ ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lucianosousa