Switch to the rubocop-shopify gem #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanahsmith
force-pushed
the
rubocop-shopify
branch
from
1590ca1 to
a39346e
Compare
dylanahsmith
commented
Mar 25, 2021
Comment on lines
+60
to
+64
| Lint/MissingSuper: | ||
| Exclude: | ||
| - 'test/executor_test.rb' | ||
| - 'test/loader_test.rb' | ||
| - 'test/support/loaders.rb' |
There was a problem hiding this comment.
Although not calling super isn't recommended, we do need to keep supporting it for backwards compatibility, so I avoided updating these offenses.
However, I've kept this non-recommended usage in the tests, since we still need to support `super` not being called in these loaders for backwards compatibility
dylanahsmith
force-pushed
the
rubocop-shopify
branch
from
e7ed0b7 to
3388377
Compare
swalkinshaw
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our rubocop config is still trying to inherit the shopify rubocop config from https://ruby-style-guide.shopify.dev/rubocop.yml which now gives a 404 error.
The recommended way of using this configuration has been to use the rubocop-shopify gem, as mentioned on https://ruby-style-guide.shopify.dev/#adoption-with-rubocop. So I've switched to using that gem and fixed some rubocop offenses from inheriting a newer config.