Return a normal Promise object from GraphQL::Batch::Loader#load #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuorig
reviewed
Sep 1, 2017
| @@ -92,6 +95,14 @@ def cache_key(load_key) | |||
|
|
|||
| private | |||
|
|
|||
| def finish_resolve(key) | |||
| promise = promise_for(key) | |||
| return yield(promise) unless executor | |||
There was a problem hiding this comment.
is this line necessary since it will raise if not wrapped in GraphQL::Batch.batch in for?
There was a problem hiding this comment.
The executor is mostly just used for storing loaders so they can be looked up for grouping, however, an alternative would be to store loaders in a context. We started supporting using loaders without an executor in #35.
xuorig
approved these changes
Sep 1, 2017
GraphQL::Batch::Promise is now deprecated and will be removed in the future, since all we used it for was to set a loading flag to `false` in the executor so that we could distinguish between batch queries performed in the loader and non-batched queries performed in the promise callbacks.
dylanahsmith
force-pushed
the
remove-derived-promise-class
branch
from
72280d9 to
076aaa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60 (cc @jpserra)
@arthurschreiber would this remove the need for lgierth/promise.rb#35 ?
As I mentioned in #60
so I refactored the code so that GraphQL::Batch::Loader's fulfill and reject methods call
executor.around_promise_callbacks doaround the actually fulfillment or rejection of the promise, allowing the executor to set its loading flag tofalsebefore promise callbacks are called and reset back totruefor the remainder of the loaders perform method.