Remix v2 #1289
Merged
Remix v2 #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
frandiox
commented
Oct 18, 2023
| @@ -59,7 +59,7 @@ export async function loader({params, request, context}: LoaderArgs) { | |||
| } | |||
|
|
|||
| if (!product.selectedVariant) { | |||
| return redirectToFirstVariant({product, request}); | |||
| throw redirectToFirstVariant({product, request}); | |||
There was a problem hiding this comment.
This makes returned types work better, and I think it doesn't change the behavior, right?
frandiox
commented
Oct 18, 2023
Comment on lines
+63
to
+66
| export const useRootLoaderData = () => { | ||
| const [root] = useMatches(); | ||
| return root?.data as SerializeFrom<typeof loader>; | ||
| }; |
There was a problem hiding this comment.
I'm adding this small abstraction to enhance types. Thoughts?
blittle
reviewed
Oct 18, 2023
blittle
reviewed
Oct 18, 2023
| } | ||
| ``` | ||
|
|
||
| This way, you can import `useRootLoaderData()` anywhere in your app and get the correct type for the data returned by the root loader. |
There was a problem hiding this comment.
This is cool, I didn't know about it.
Co-authored-by: Bret Little <bret.little@shopify.com>
This was referenced Oct 19, 2023
wizardlyhel
approved these changes
Oct 25, 2023
I had links to the Remix release notes in the demo-store changeset but I've now added the same links to the other packages. Also added a couple of common examples 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI We'll release v2 support in our next major bump to avoid breaking changes for users in minor/patch releases.
This is just to track the required changes for supporting Remix v2.
I had to add a fewFixed!@ts-ignoredue to a bug in the types: remix-run/remix#7246Should be fixed for v2 stable I think.
Todos:
@ts-ignorecommentsNote: the preview environment in this PR shows the demo-store and it has unrelated errors due to the new CSP